Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hard-require zram-generator-default on RHEL just yet #3168

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Feb 12, 2021

Drop the hard Requires on zram-generator-defaults for RHEL builds,
until it's build issues on RHEL are resolved.

@M4rtinK M4rtinK added master Please, use the `f39` label instead. f34 labels Feb 12, 2021
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise.

anaconda.spec.in Outdated
@@ -237,7 +237,10 @@ Requires: gdb
Requires: rsync
# only WeakRequires elsewhere and not guaranteed to be present
Requires: device-mapper-multipath
# do not require on RHEL until the package is ready
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this comment as FIXME.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea, changed! :)

@M4rtinK M4rtinK changed the base branch from master to f34-devel February 12, 2021 17:21
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@M4rtinK M4rtinK force-pushed the master-do_not_require_zram_generator_on_RHEL9_just_now branch from 7341dc3 to c5ecffa Compare February 12, 2021 17:23
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request needs to be rebased and it would be nice to add a number of the related bug if there is any.

@M4rtinK M4rtinK force-pushed the master-do_not_require_zram_generator_on_RHEL9_just_now branch from c5ecffa to 2da5de6 Compare February 15, 2021 15:51
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Feb 15, 2021

The pull request needs to be rebased and it would be nice to add a number of the related bug if there is any.

Rebased on latest f34-devel. As for a bug number, I'm afraid there is not any as far as I can tell for this issue.

Drop the hard Requires on zram-generator-defaults for RHEL builds,
until it's build issues on RHEL are resolved.
@M4rtinK M4rtinK force-pushed the master-do_not_require_zram_generator_on_RHEL9_just_now branch from 2da5de6 to 63c6ddd Compare February 15, 2021 15:55
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@M4rtinK M4rtinK merged commit 04f4e23 into rhinstaller:f34-devel Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f34 master Please, use the `f39` label instead.
4 participants