-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hard-require zram-generator-default on RHEL just yet #3168
Do not hard-require zram-generator-default on RHEL just yet #3168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise.
anaconda.spec.in
Outdated
@@ -237,7 +237,10 @@ Requires: gdb | |||
Requires: rsync | |||
# only WeakRequires elsewhere and not guaranteed to be present | |||
Requires: device-mapper-multipath | |||
# do not require on RHEL until the package is ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this comment as FIXME.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice idea, changed! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
7341dc3
to
c5ecffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request needs to be rebased and it would be nice to add a number of the related bug if there is any.
c5ecffa
to
2da5de6
Compare
Rebased on latest f34-devel. As for a bug number, I'm afraid there is not any as far as I can tell for this issue. |
Drop the hard Requires on zram-generator-defaults for RHEL builds, until it's build issues on RHEL are resolved.
2da5de6
to
63c6ddd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
Drop the hard Requires on zram-generator-defaults for RHEL builds,
until it's build issues on RHEL are resolved.