packit: generate config.h after cloning the repo #3170
Conversation
I hope this will trigger regeneration of config.h in CI Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
since create-archive and post-upstream-clone are running in different environments, paths in Makefiles written from autogen.sh and configure are no longer valid in the create-archive action Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
|
/packit build |
|
The ELN build indeed failed but the one for rawhide never started: https://copr.fedorainfracloud.org/coprs/packit/rhinstaller-anaconda-3170/builds/ |
|
/packit build |
|
Wow, thanks a lot for finding this! It's totally weird... I still wonder why the runs are isolated? Seems to me like something which shouldn't be happening when it's in the same action. Also is this PR ready for merge? |
It's a deficiency which we are going to fix on our side: https://issues.redhat.com/browse/PACKIT-1133
yup, ready to be merged, was hoping to get a green eln build but didn't happen yet |
|
OK, thanks! Could you please rebase this solution to Also wouldn't it be better to just do everything on one line to avoid this problem? |
Can do!
I hope that in a week or two, we'll change the sandbox on our side so it's consistent for all action runs. Yes, we can drop the post-upstream-clone and move everything to create-archive - that's a solution as well. |
|
That sounds great! In that case would it be possible to add FIXME comment with link to the issue you posted here? Thanks! |
|
closed in favour of #3181 |
since create-archive and post-upstream-clone are running in different
environments, paths in Makefiles written from autogen.sh and configure
are no longer valid in the create-archive action
This should resolve: https://prod.packit.dev/srpm-build/13919/logs
Full context: https://blog.tomecek.net/post/automake-in-openshift/ :)