Check if gnome-icon-theme is installed #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
improve_glade_icon_test
branch
from
896c205
to
25f74c3
Compare
|
also checks for gnome-icon-theme-symbolic |
| @@ -5,6 +5,18 @@ if ! type parallel 2>&1 > /dev/null; then | |||
| exit 99 | |||
| fi | |||
|
|
|||
| if ! rpm -q gnome-icon-theme 2>&1 > /dev/null; then | |||
There was a problem hiding this comment.
I think ! rpm -q gnome-icon-theme &> /dev/null; would be better here and few lines below too.
|
Other than the minor comment above this looks good to me. |
are installed otherwise tests/glade/icons/check_icons.py produces false negatives
atodorov
force-pushed
the
improve_glade_icon_test
branch
from
25f74c3
to
4148688
Compare
|
It looks like we'd need this on master too, right? |
Yes |
|
Pushed to both master and rhel7-branch. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just minimize the false negatives when this is installed.