Add display-related dependencies #3235
Conversation
VladimirSlavik
force-pushed
the
master-display-utils-in-spec
branch
from
fd100e6
to
da619e2
Compare
anaconda.spec.in
Outdated
| @@ -201,6 +201,9 @@ Requires: gdb | |||
| # support for installation from image and live & live image installations | |||
| Requires: rsync | |||
| Recommends: zram-generator-defaults | |||
| # Display stuff moved from lorax templates | |||
| Requires: xhost | |||
| Requires: xorg-x11-xauth | |||
There was a problem hiding this comment.
I don't think anaconda calls xauth.
There was a problem hiding this comment.
I see it in the sshd_config.anaconda file in lorax, but nowhere else. https://github.com/weldr/lorax/blob/master/share/templates.d/99-generic/config_files/common/sshd_config.anaconda
There was a problem hiding this comment.
Thanks! Vlada, could you add there a comment that xorg-x11-xauth is a dependency of the anaconda-sshd service?
There was a problem hiding this comment.
Thanks! Done.
There was a problem hiding this comment.
@bcl Is there any reason for allowing X11Forwarding in sshd_config.anaconda?
This was needed in the past when it was possible to execute graphical installation via X11 forwarding on s390x, but this is not supported/possible since RHEL-7 any more.
There was a problem hiding this comment.
After a more careful look, I'm no longer sure about where xauth goes (-img- or -env-). Earlier, I got "it's used by liveinst setup script" but now I see it in sshd_config.anaconda, which is used by runtime-postinstall.tmpl, which is documented as altering the installer environment.
There was a problem hiding this comment.
@jstodola I doubt it's useful anymore, and looking at the Anaconda logs it appears this was first added in 2004 for s390. Things have changed a whole bunch since then ;)
There was a problem hiding this comment.
The xauth package is now removed here. I've updated the lorax template changes to do that too: weldr/lorax#1125
VladimirSlavik
force-pushed
the
master-display-utils-in-spec
branch
from
da619e2
to
73054b7
Compare
|
/packit test |
|
/kickstart-test --testtype smoke |
VladimirSlavik
force-pushed
the
master-display-utils-in-spec
branch
from
73054b7
to
adec865
Compare
Moved from lorax-templates. See also: https://listman.redhat.com/archives/anaconda-devel-list/2021-March/msg00001.html Removes support for forwarding X, which was of dubious status already. There are no known users and boot.iso can run a VNC server, which is a documented capability.
VladimirSlavik
force-pushed
the
master-display-utils-in-spec
branch
from
adec865
to
f9f190d
Compare
|
Removed xauth, see review discussion above. Ready to merge. Once released, unblocks weldr/lorax#1125 |
|
/kickstart-test --testtype smoke |
|
Requested workflow run has to be approved. You can do that here |
Moved from lorax-templates, with the exception of metacity. See also:
https://listman.redhat.com/archives/anaconda-devel-list/2021-March/msg00001.html