Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install kbd-legacy if keyboard layout is "fi" (#1955793) #3344

Merged
merged 1 commit into from May 20, 2021

Conversation

AdamWill
Copy link
Contributor

@AdamWill AdamWill commented May 5, 2021

fi is a special case, as described in
https://bugzilla.redhat.com/show_bug.cgi?id=1955793#c6 , where
the layout is taken from kbd-legacy even though the xkb layout
does support ASCII input. So we have to special-case it here.

Signed-off-by: Adam Williamson awilliam@redhat.com

fi is a special case, as described in
https://bugzilla.redhat.com/show_bug.cgi?id=1955793#c6 , where
the layout is taken from kbd-legacy even though the xkb layout
does support ASCII input. So we have to special-case it here.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill AdamWill temporarily deployed to staging May 5, 2021 23:53 Inactive
@AdamWill AdamWill temporarily deployed to staging May 5, 2021 23:53 Inactive
@poncovka poncovka added the master Please, use the `f39` label instead. label May 6, 2021
@poncovka
Copy link
Contributor

poncovka commented May 6, 2021

/kickstart-test --testtype smoke

@github-actions
Copy link

github-actions bot commented May 6, 2021

Requested workflow run has to be approved. You can do that here

@poncovka poncovka self-assigned this May 6, 2021
@poncovka poncovka added the manual testing required This issue can't be merged without manual testing label May 6, 2021
@poncovka
Copy link
Contributor

poncovka commented May 6, 2021

Unfortunately, it doesn't fix the issue, because vc_keymap is not always set. I will have to look into that a little more.

@poncovka poncovka added the blocked Don't merge this pull request! label May 6, 2021
@poncovka
Copy link
Contributor

Blocked by #3372.

@poncovka poncovka removed blocked Don't merge this pull request! manual testing required This issue can't be merged without manual testing labels May 20, 2021
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@poncovka poncovka merged commit d896c85 into rhinstaller:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
2 participants