Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boot-options.rst #3530

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

Ultimate-etamitlU
Copy link
Contributor

There was confusion in inst.selinux=0 as,

Original :

Enable SELinux usage in the installed system (default). Note that when used as a boot option, “selinux” and “inst.selinux” are not the same. The “selinux” option is picked up by both the kernel and Anaconda, but “inst.selinux” is processed only by Anaconda. So when “selinux=0” is used, SELinux will be disabled both in the installation environment and in the installed system, but when “inst.selinux=0” is used SELinux will only be disabled in the installed system. Also note that while SELinux is running in the installation environment by default, it is running in permissive mode so disabling it there does not make much sense.

Change:

Enable SELinux usage in the installed system (default). Note that when used as a
boot option, "selinux" and "inst.selinux" are not the same. The "selinux" option
is picked up by both the kernel and Anaconda, but "inst.selinux" is processed
only by Anaconda. So when "selinux=0" is used, SELinux will be disabled both in
the installation environment and in the installed system, but when
"inst.selinux=0" is used SELinux will only be disabled in the installation environment.
Also note that while SELinux is running in the installation environment by
default, it is running in permissive mode so disabling it there does not make
much sense.

There was confusion in inst.selinux=0 as,

Original : 


Enable SELinux usage in the installed system (default). Note that when used as a boot option, “selinux” and “inst.selinux” are not the same. The “selinux” option is picked up by both the kernel and Anaconda, but “inst.selinux” is processed only by Anaconda. So when “selinux=0” is used, SELinux will be disabled both in the installation environment and in the installed system, but when “inst.selinux=0” is used SELinux will only be disabled in the installed system. Also note that while SELinux is running in the installation environment by default, it is running in permissive mode so disabling it there does not make much sense.

Change: 

Enable SELinux usage in the installed system (default). Note that when used as a
boot option, "selinux" and "inst.selinux" are not the same. The "selinux" option
is picked up by both the kernel and Anaconda, but "inst.selinux" is processed
only by Anaconda. So when "selinux=0" is used, SELinux will be disabled both in
the installation environment and in the installed system, but when
"inst.selinux=0" is used SELinux will only be disabled in the installation environment.
Also note that while SELinux is running in the installation environment by
default, it is running in permissive mode so disabling it there does not make
much sense.
@jkonecny12
Copy link
Member

Hi, thanks for the change. Just a small correction, we implemented this fedora change so we are no more reading or using kernel parameters without inst. prefix.

@jkonecny12 jkonecny12 added the master Please, use the `f39` label instead. label Jul 22, 2021
@jkonecny12
Copy link
Member

/kickstart-test --testtype smoke

@Ultimate-etamitlU
Copy link
Contributor Author

Yes, we shall not read prefix without "inst." , the change I requested is to the confusing statement in the documentation. Red Hat documentation has the correct definition for those. It's just we need to replace "installed system" to "installed environment" as
"inst.selinux will allow to change mode of installation environment of anaconda and not the actual system which is being getting installed."

@VladimirSlavik
Copy link
Contributor

Thank you, the change is probably correct.

FWIW, I think copying the whole paragraph here was a mistake, now we're all hung up on the "we need prefix inst."... ;-)

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the patch.

@rvykydal rvykydal merged commit fbfc700 into rhinstaller:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
4 participants