F23 dnf root size #358
Closed
F23 dnf root size #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me otherwise. |
jkonecny12
force-pushed
the
f23-dnf-root-size
branch
from
183a194
to
62b5a01
Compare
|
Updated, thank you @vpodzime |
| @@ -58,6 +58,7 @@ | |||
| DNF_CACHE_DIR = '/tmp/dnf.cache' | |||
| DNF_PLUGINCONF_DIR = '/tmp/dnf.pluginconf' | |||
| DNF_PACKAGE_CACHE_DIR_SUFFIX = 'dnf.package.cache' | |||
| INSTALL_ROOT_MPOINT = '/mnt/sysimage' | |||
There was a problem hiding this comment.
You can't assume this anymore. Use iutil.getSysroot() instead.
There was a problem hiding this comment.
Good catch I'm going to update PR.
Anaconda must compute size for downloaded and installed packages when testing free space for installed root. Resolves: rhbz#1224048
We need to reduce the disk capacity for space required comparison because fs takes some for metadata. Related: rhbz#1224048
jkonecny12
force-pushed
the
f23-dnf-root-size
branch
from
62b5a01
to
decd61f
Compare
|
PR was updated according to @bcl comment. Thank you |
|
Pushed. Thank you for help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anaconda must compute size for downloaded and installed packages when testing free space for installed root. Also use only 90% of disk capacity for required space compare.
Resolves: rhbz#1224048