Backport pytest migration to rhel-9 #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladimirSlavik
approved these changes
Oct 25, 2021
I recommend waiting at least for #3651 to be merged as that PR has quite a few changes in tests and is already on ready-to-merge state. |
|
It could be good to add also #3608 which is one commit. |
poncovka
approved these changes
Oct 29, 2021
|
PR #3651 has been merged, so its not longer blocking pytest migration on RHEL 9. |
|
Yes, I know. I just did not had time to finish this but planning to look on that soon. |
jkonecny12
force-pushed
the
rhel-9-backport-pytest
branch
2 times, most recently
from
6f11b87
to
6984ba0
Compare
|
UPDATED |
jkonecny12
commented
Nov 30, 2021
tests/unit_tests/pyanaconda_tests/modules/subscription/test_subscription.py
Show resolved
Hide resolved
|
UPDATED: |
jkonecny12
force-pushed
the
rhel-9-backport-pytest
branch
from
27ea71b
to
50828c6
Compare
|
UPDATED:
|
jkonecny12
force-pushed
the
rhel-9-backport-pytest
branch
from
50828c6
to
0a29bb5
Compare
|
/kickstart-test --testtype smoke |
Python3 unittests need to have `test_*` prefix otherwise they are ignored. On the other hand nosetest took `test_*`, `*_test.py` or even `*_tests.py`. (cherry picked from commit 3fbff2c)
This make the tests discoverable by python3 unittest framework. (cherry picked from commit e0c1928)
We need to migrate away from nosetests because they are not compatible with python 3.10. Let's finally do the step. (cherry picked from commit 0bf0aa7)
First we are running these by unittest python3 framework and second this name could stay even in future when we migrate away from the unittest framework. Fix import paths in tests too. (cherry picked from commit 2306137)
Better name in general. Not referring nose framework which we don't use now anymore. Remove nosetests_root.sh because the tests it's pointing does not exists. This is breaking change but it shouldn't be such a pain because I don't think there are many users (other than from terminal) who use the `UNIT_TESTS_ARGS` Makefile var or the `tests-unit-only` Makefile target. `UNIT_TESTS_ARGS` now pass arguments to the `unittest discover` python module. Change documentation to reflect that. (cherry picked from commit df1c352)
…fra) Rename it to UNIT_TESTS_PATTERN and pass this argument to the `python3 -m unittest discover -k` parameter. (cherry picked from commit 769efda)
Show how to use the new UNIT_TESTS_PATTERN variable and fix name changes. (cherry picked from commit 498fa42)
…fra) The unittest framework is matching `test*` files. (cherry picked from commit d701c61)
We used nose tests but it doesn't work anymore on python 3.10. Let's finally migrate away. Add future TODO to solve RPM_TESTS_ARGS parameter. (cherry picked from commit 094a950)
Having 'test' keyword in the middle was fine for nosetests but not for unittests and I don't blame them.
- Convert from nose to unittest - Launch via shell script, same as unit and rpm tests - Remove unused capabilities: - No options can't be passed to this test any more - Do not consider translations - No longer test only specific files - Simplify format and layout of the individual tests and helper code: - Make glade test common code a module, no class needed any more - Merge test classes where applicable - Rename directory (cherry picked from commit 69e17f5)
All the tests seems to be working as they should and the error reporting is 100% better than with unit-tests. (cherry picked from commit a473b59)
During this some of code bad habits were discovered. old bad habbit -> pytest self.assertEquals(value, None) -> assert value is None Also the output is a bit smaller so some test code could be moved to one line. (cherry picked from commit 2139937)
(cherry picked from commit b5719b0)
We don't need this with pytest. All the asserts in pytest are separated statements. (cherry picked from commit 16260f5)
On a few places in the code we used: self.assertRaises(Exception, msg="message of exception"): However, this is not a valid usage. The `msg` argument here is replacement of the error message raised from the assert, not a message of the exception to compare. The conversion script to pytest dropped these `msg` arguments (probably because pytest doesn't support them). So I'm fixing these tests now. (cherry picked from commit 4abaf2d)
Sometimes we compare large data structures and we need to see full diff. (cherry picked from commit 73cb6e9)
Don't propagate these warnings to the unit tests summary. (cherry picked from commit aa6ef21)
Use '==' instead of 'is' to resolve the following warning: SyntaxWarning: "is" with a literal. Did you mean "=="? (cherry picked from commit 837f22b)
The __pycache__ folder is created during local run of the code and it shouldn't be taken as a test issue.
The assert introspection works by default only for test modules. It means that helper functions from other modules will raise the AssertionError exception without any other useful information. These modules have to be explicitly registered with the register_assert_rewrite function to make the assert introspection work. See: https://docs.pytest.org/en/6.2.x/writing_plugins.html#assertion-rewriting (cherry picked from commit 17a3eb7)
These were previously changed in bulk after switch to pytest. (cherry picked from commit a6cfb29)
jkonecny12
force-pushed
the
rhel-9-backport-pytest
branch
from
0a29bb5
to
7bda021
Compare
|
UPDATED:
|
|
/kickstart-test --testtype smoke |
jstodola
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this big change I'm backporting and fixing code from upstream. It's transition from nosetests -> unittests -> pytest. Sorry for this being so big.
This PR is backport of:
#3445
#3553
#3473
#3567
To make this works, first it needs to be rebased on top of #3661.
Also we need to decide if want to first merge pending changes to
rhel-9branch and do the changes on the branch or opposite.