bug fix: activate connection from callback _connection_updated_cb #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rvykydal, could you review this pull request, please? |
rvykydal
added
manual testing required
rvykydal
approved these changes
Nov 2, 2021
|
@rvykydal, Passing the nm_client instance was also my first thinking in the beginning. But later I decided to get it on the fly to keep this fix small and interfaces clean, as the nm_client is already being well cached for us from the network module. We may overhaul this part when we have more things to pass between the two spokes. |
|
/kickstart-test --testtype smoke |
|
@qyng please remove the added merge commits from the branch. |
this is the correct order ui.tui.spokes.network: updating connection ... ui.tui.spokes.network: updated connection ... ui.tui.spokes.network: activating connection ... otherwise it could be wrong as ui.tui.spokes.network: updating connection ... ui.tui.spokes.network: activating connection ... ui.tui.spokes.network: updated connection ...
|
/kickstart-test --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix: activate connection from callback _connection_updated_cb
this is the correct order
ui.tui.spokes.network: updating connection ...
ui.tui.spokes.network: updated connection ...
ui.tui.spokes.network: activating connection ...
otherwise it could be wrong as
ui.tui.spokes.network: updating connection ...
ui.tui.spokes.network: activating connection ...
ui.tui.spokes.network: updated connection ...