Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for all background threads to finish before filling installation… #3722

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Nov 25, 2021

… task queue

Otherwise installation tasks, such as the installation task that
transfers subscription tokens, will be scheduled based on stale data
(eq. system is not subscribed as the subscription thread is still
running).

By waiting for all background processing threads to finish before
assembling the installation task queue, we will make sure all tasks are
correctly scheduled based on up to data data - eq. system was
successfully registered, so the token transfer task needs to transfer
the relevant subscription tokens to the target system.

(cherry picked from commit 734befd)
(cherry picked from commit f353930)

Resolves: rhbz#2017428

… task queue

Otherwise installation tasks, such as the installation task that
transfers subscription tokens, will be scheduled based on stale data
(eq. system is not subscribed as the subscription thread is still
running).

By waiting for all background processing threads to finish before
assembling the installation task queue, we will make sure all tasks are
correctly scheduled based on up to data data - eq. system was
successfully registered, so the token transfer task needs to transfer
the relevant subscription tokens to the target system.

(cherry picked from commit 734befd)
(cherry picked from commit f353930)

Resolves: rhbz#2017428
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 25, 2021

Upstream PR: #3720
RHEL 8 PR: #3704

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Nov 25, 2021

/kickstart-test --testtype smoke

Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rvykydal
Copy link
Contributor

/kickstart-test --testtype smoke

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Nov 26, 2021
@rvykydal rvykydal merged commit c9ffd65 into rhinstaller:rhel-9 Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
3 participants