Improve Simple Content Access UX (RHEL 8) #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't merge this until subscription-manager 1.28.26 has been released an is available in the compose. So setting the blocked label. |
M4rtinK
force-pushed
the
rhel-8-improve_SCA_UX
branch
from
41843c1
to
f8177f1
Compare
Add support for detecting Single Content Access mode from data returned by the RHSM DBus API Register() and RegisterWithActivationKeys() methods. As the parsing function is used in two places, put it into an utils module. Related: rhbz#1968574
M4rtinK
force-pushed
the
rhel-8-improve_SCA_UX
branch
from
f8177f1
to
36d7429
Compare
poncovka
suggested changes
Feb 15, 2022
M4rtinK
force-pushed
the
rhel-8-improve_SCA_UX
branch
from
36d7429
to
d3e65ee
Compare
Pylint issues have been fixed up. :) |
|
/kickstart-test --testtype smoke |
|
https://bugzilla.redhat.com/show_bug.cgi?id=2049101 with subscription-manager-1.28.28-1.el8 is in ON_QA, so this PR is not blocked by subscription-manager any more. |
Yeah, dropping the blocked label. :) |
jkonecny12
approved these changes
Feb 21, 2022
| @@ -241,13 +243,14 @@ def run(self): | |||
| # We do not yet support setting organization for username & password | |||
| # registration, so organization is blank for now. | |||
| organization = "" | |||
| private_register_proxy.Register(organization, | |||
| registration_data = private_register_proxy.Register(organization, | |||
| self._username, | |||
| self._password, | |||
| {}, | |||
| {}, | |||
| locale) | |||
There was a problem hiding this comment.
Yep, that
s all
wrong.
Should be fixed now.
poncovka
approved these changes
Feb 22, 2022
Add the IsSimpleContentAccessEnabled property to the Subscription module DBus interface. This property is set to True if SCA mode is detected after a successfully registration attempt. The property is reset back to the initial state (False) on unregistration. Related: rhbz#1968574
Instead of showing "No subscriptions attached" on the Connect to Red Hat screen in SCA mode show "Subscribed in Simple Content Access mode." instead. Resolves: rhbz#1968574
The necessary API support for returning Simple Content Access mode as part of registration data & working SCA+auto-attach needs at least 1.28.26. Related: rhbz#1968574
M4rtinK
force-pushed
the
rhel-8-improve_SCA_UX
branch
from
d3e65ee
to
0370bf7
Compare
Issue has been fixed. |
|
/kickstart-test --testtype smoke |
M4rtinK
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a proper status message instead of a confusing (even if correct) message about no subscription being attached if install time registration is done in Simple Content Access mode.
This is achieved by parsing the data returned by the register methods of the RHSM DBus, exposing this via a DBus property of the Subscription module, which is then used by the GUI to display the appropriate string.
This is the RHEL 8 version of #3828.