Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fingerprint authentication using enable-feature #3991

Merged
merged 1 commit into from Mar 31, 2022
Merged

Enable fingerprint authentication using enable-feature #3991

merged 1 commit into from Mar 31, 2022

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Mar 30, 2022 •
edited

Don't select a profile to enable fingerprint authentication. Call enable-feature
to enable the with-fingerprint feature in the currently selected profile instead.

Related: rhbz#2056927
Resolves: rhbz#2069899

@poncovka poncovka added f36 f37 Fedora 37 labels Mar 30, 2022
@poncovka
Enable fingerprint authentication using enable-feature (#2069899)
a497ac1 
Don't select a profile to enable fingerprint authentication. Call enable-feature
to enable the with-fingerprint feature in the currently selected profile instead.

Related: rhbz#2056927
Resolves: rhbz#2069899
M4rtinK
M4rtinK approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

@AdamWill
Copy link
Contributor

For the record, --enable-feature has existed since 2018 so this should be OK on all vaguely current Fedoras/RHELs, I think.

jkonecny12
jkonecny12 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pbrezina
Copy link
Contributor

LGTM. Doesn't Anaconda run authselect select sssd with-silent-lastlog --force somewhere also without fingerprint? If yes, it should be removed. Installation of the authselect package will do this automatically in its %post.

@pbrezina
Copy link
Contributor

LGTM. Doesn't Anaconda run authselect select sssd with-silent-lastlog --force somewhere also without fingerprint? If yes, it should be removed. Installation of the authselect package will do this automatically in its %post.

Please note that this behavior is new in Fedora 36, it will be probably picked up by RHEL-10 but it is not available if earlier Fedora releases nor in RHEL-8/9. So this whole PR should aim at Fedora 36+ only.

@poncovka
Copy link
Contributor Author

/kickstart-test --testtype smoke

@poncovka
Copy link
Contributor Author

LGTM. Doesn't Anaconda run authselect select sssd with-silent-lastlog --force somewhere also without fingerprint? If yes, it should be removed. Installation of the authselect package will do this automatically in its %post.

It doesn't. We run authselect, if it is specified in a kickstart file, and to enable the fingerprint authentication. That's it.

Please note that this behavior is new in Fedora 36, it will be probably picked up by RHEL-10 but it is not available if earlier Fedora releases nor in RHEL-8/9. So this whole PR should aim at Fedora 36+ only.

That should be fine.

@poncovka poncovka merged commit a42ad6b into rhinstaller:f36-devel Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
f36 f37 Fedora 37
Milestone
No milestone
5 participants
@poncovka @AdamWill @pbrezina @M4rtinK @jkonecny12