Web UI: Add a log viewer #4184
Web UI: Add a log viewer #4184
Conversation
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
from
cbbdd7c
to
8aba366
Compare
|
Remainig issues to fix for this PR:
|
| @@ -179,6 +182,10 @@ const Footer = ({ isFormValid, setIsFormValid, setStepNotification, isInProgress | |||
| exitGui={exitGui} | |||
| setQuitWaitsConfirmation={setQuitWaitsConfirmation} | |||
| />} | |||
| {showLogViewer && | |||
| <LogViewerModal | |||
There was a problem hiding this comment.
I don't see a relation between a footer and a log viewer. There is no reason why the modal component should be here.
There was a problem hiding this comment.
Looks like for some reason we have many modals defined here - might be a good idea to move those as well to some more sensible place.
There was a problem hiding this comment.
These modals are there because they are somehow tied to the actions of the footer.
There was a problem hiding this comment.
Turns out this indeed fits well on the top level next to the help drawer - just took me some time to figure it out. :P
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
from
8aba366
to
1da6afc
Compare
|
PR updated - thanks a lot for all the feedback so far! :) |
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
from
1da6afc
to
0f7d76f
Compare
| <Flex direction={{ default: "column" }}> | ||
| <TextContent> | ||
| <Text component={TextVariants.p}> | ||
| {_("Installer version") + " 37.10"} |
There was a problem hiding this comment.
The hardcoded version isn't very nice, but let's not drag webpack macros into this yet.
There was a problem hiding this comment.
I think eventually we want to just fetch it via DBus from the backend, right ? Or is it set somewhere else where we can reach, like the config file ?
There was a problem hiding this comment.
For python we have pyanaconda/version.py.in, so I would expect the same...
| // - without this the line number column is too narrow | ||
| // and line numbers quickly become unreadable | ||
| .pf-c-log-viewer__index { | ||
| width: auto; |
There was a problem hiding this comment.
Doesn't this make the UI jump if new numbers are added and are longer? Eg. 99->100.
Perhaps also min-width: 3rem; or some such could be useful to prevent the log from jumping too much in the beginning when the render length of line numbers grows faster.
There was a problem hiding this comment.
I wouldn't mess with it more that we do now. It is a workaround for a bug in Patternfly anyway.
|
This PR is stale because it has been open 60 days with no activity. |
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
2 times, most recently
from
2038ec3
to
47bdc9a
Compare
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
from
47bdc9a
to
e62d74c
Compare
Add a log viewer that opens in a modal window when the "Show logs" button in the upper right corner of the screen is clicked. The log viewer is currently hardcoded to follow /tmp/anaconda.log. Also add tests and resuable test functions.
M4rtinK
force-pushed
the
master-add_log_viewer_to_the_web_ui
branch
from
e62d74c
to
da7c32c
Compare
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR was closed because it has been stalled for 30 days with no activity. |
|
This PR is stale because it has been open 60 days with no activity. |
|
This PR was closed because it has been stalled for 30 days with no activity. |
Add a log viewer that opens in a modal window when the
"Show logs" button in the upper right corner of the screen
is clicked.
The log viewer is currently hardcoded to follow /tmp/anaconda.log.