Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dracut: handle compressed kernel modules #4191

Merged
merged 1 commit into from Oct 6, 2022

Conversation

mikhailnov
Copy link
Contributor

Compressed kernel modules could not be loaded.
Now both compressed and not compressed ones will be loaded.

$ uname -r
5.10.74-generic-2rosa2021.1-x86_64
$ ls -1v /lib/modules/$(uname -r)/kernel/drivers/scsi/device_handler/
scsi_dh_alua.ko.zst
scsi_dh_emc.ko.zst
scsi_dh_hp_sw.ko.zst
scsi_dh_rdac.ko.zst

Replaces #3501
Noted by slava86@

@M4rtinK M4rtinK added the manual testing required This issue can't be merged without manual testing label Jun 14, 2022
@M4rtinK
Copy link
Contributor

M4rtinK commented Jun 14, 2022

/kickstart-test --testtype smoke

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The code seems to work correctly in terminal. @mikhailnov did you test this on actual ISOs?

@mikhailnov
Copy link
Contributor Author

mikhailnov commented Jun 14, 2022 via email

@poncovka
Copy link
Contributor

/kickstart-test --testtype smoke

@VladimirSlavik
Copy link
Contributor

I have not made iSCSI fully workable yet.

Well, this bit should be helpful on its own, I think? I can't speak for the whole team but loading also compressed modules seems like an improvement, even if it's one step towards some goal.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 15, 2022
@jkonecny12
Copy link
Member

@VladimirSlavik @mikhailnov is this PR ready to be merged? It seems to me like that.

@github-actions github-actions bot removed the stale label Aug 16, 2022
Compressed kernel modules could not be loaded.
Now both compressed and not compressed ones will be loaded.

$ uname -r
5.10.74-generic-2rosa2021.1-x86_64
$ ls -1v /lib/modules/$(uname -r)/kernel/drivers/scsi/device_handler/
scsi_dh_alua.ko.zst
scsi_dh_emc.ko.zst
scsi_dh_hp_sw.ko.zst
scsi_dh_rdac.ko.zst

Replaces rhinstaller#3501
Noted by slava86@
@mikhailnov
Copy link
Contributor Author

Yes, it's ready to be merged, sorry, I forgot to add "-r" to "read", added it

Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@poncovka
Copy link
Contributor

/kickstart-test --testtype smoke

@VladimirSlavik VladimirSlavik added f38 Fedora 38 and removed manual testing required This issue can't be merged without manual testing labels Oct 6, 2022
@VladimirSlavik VladimirSlavik merged commit 95dc7f8 into rhinstaller:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f38 Fedora 38
5 participants