New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dracut: handle compressed kernel modules #4191
Conversation
/kickstart-test --testtype smoke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The code seems to work correctly in terminal. @mikhailnov did you test this on actual ISOs?
Yes, it seems to work, at least it does not say that it failed to load kernel modules. I have not made iSCSI fully workable yet. For example, ROSA package of multipath-tools did not have mpathconf utility which is carried as a patch in the Fedora/RH package and does not exisf in upstream, Anaconda failed to start if multipath-tools was installed but mpathconf did not exist. Now it exists but python-blivet gets an error from udisks2, I will examine it a bit later.
|
/kickstart-test --testtype smoke |
Well, this bit should be helpful on its own, I think? I can't speak for the whole team but loading also compressed modules seems like an improvement, even if it's one step towards some goal. |
This PR is stale because it has been open 60 days with no activity. |
@VladimirSlavik @mikhailnov is this PR ready to be merged? It seems to me like that. |
Compressed kernel modules could not be loaded. Now both compressed and not compressed ones will be loaded. $ uname -r 5.10.74-generic-2rosa2021.1-x86_64 $ ls -1v /lib/modules/$(uname -r)/kernel/drivers/scsi/device_handler/ scsi_dh_alua.ko.zst scsi_dh_emc.ko.zst scsi_dh_hp_sw.ko.zst scsi_dh_rdac.ko.zst Replaces rhinstaller#3501 Noted by slava86@
57ec67f
to
c4a388d
Compare
Yes, it's ready to be merged, sorry, I forgot to add "-r" to "read", added it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you!
/kickstart-test --testtype smoke |
Compressed kernel modules could not be loaded.
Now both compressed and not compressed ones will be loaded.
$ uname -r
5.10.74-generic-2rosa2021.1-x86_64
$ ls -1v /lib/modules/$(uname -r)/kernel/drivers/scsi/device_handler/
scsi_dh_alua.ko.zst
scsi_dh_emc.ko.zst
scsi_dh_hp_sw.ko.zst
scsi_dh_rdac.ko.zst
Replaces #3501
Noted by slava86@