-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off audit instead of using a custom binary to trap output #4358
Turn off audit instead of using a custom binary to trap output #4358
Conversation
/kickstart-test --testtype smoke edit: Ah, yes, dropping the binary invalidates lorax templates, so kickstart tests won't even start until the lorax PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - nice cleanup! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great improvement!
Hi Brian @bcl, could you please make another rawhide lorax release? The changes are merged but not released yet, so this is blocked... |
New lorax tagged, waiting for the repos... https://koji.fedoraproject.org/koji/buildinfo?buildID=2074269 |
/kickstart-test --testtype smoke |
This runs
auditctl -e 0
instead of our custom binary that eats audit messages.Depends on weldr/lorax#1271
Previously:
Now:
auditctl -e 0
instead of the custom binaryOverall goals remain the same and met:
Note: Most audit messages come from dracut, where it is not turned off anyway.
Note 2: To have no audit messages, boot with
audit=0