Improvements for running at low resolutions #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the reclaim window to scroll horizontally since, just as a for instance, sometimes the label we're trying to display got set to "Red Hat Enterprise Linux Server 7.2 for ppc64le" which does not fit in the tiny windows that the system I just described insists upon using. Also also the disk label column to be shrunk in case the user doesn't care about all of that.
Move the two language strings (native and English) into a single column so that the strings in each row can be positioned independent of other rows. Allow the English string to be ellipsized so that the really long ones (e.g., Norwegian Bokmal) don't cut off the right side of the TreeView and mess up the layout. Allow the locale selection pane to scroll horizontally in order to handle long locale names (one of the Chinese locales does not fit at 800x600), and change the column sizing from Grow Only to Automatic to allow the column to shrink back when switching to other locales. This way the scrollbar is only shown when needed.
Change the grid width of all the wired property strings so that they share horizontal space with the on/off button. Otherwise IPv6 addresses will blow out the window at 800x600. Wireless already does this.
|
Looks good to me. |
|
In the first commit comment: " Also also the disk label column to be shrunk in case the user doesn't care about all of that." I think there is miss-type and should be only one also. |
|
Other than that seems good to me. |
|
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.