Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dmraid and nodmraid boot options #4517

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Remove the dmraid and nodmraid boot options #4517

merged 1 commit into from
Feb 2, 2023

Conversation

vojtechtrefny
Copy link
Contributor

These control the blivet dmraid flag which is being removed. We are switching to mdadm for Firmware/BIOS RAID support in Fedora, see https://fedoraproject.org/wiki/Changes/UseMdadmForBIOSRAIDInAnaconda

Note that this can be merged separately from the blivet change, but it would probably be better to wait for storaged-project/blivet#1098 to be merged first.

poncovka
poncovka approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

docs/boot-options.rst Show resolved Hide resolved
data/anaconda_options.txt Show resolved Hide resolved
@poncovka poncovka added blocked Don't merge this pull request! release note required Write a release note for this change. f38 Fedora 38 labels Jan 20, 2023
@poncovka poncovka self-assigned this Jan 20, 2023
@vojtechtrefny
Copy link
Contributor Author

One problem with the nodmraid flag is that it is also used outside Anaconda -- mdadm udev rules use it together with noiswmd to disable autoactivation of the BIOS/Firmware RAID arrays. But I guess this doesn't really concern Anaconda -- in Anaconda it only controls the blivet dmraid flag which we are removing and I assume that from Anaconda point of view it doesn't matter that nodmraid (without the inst prefix) is still a valid flag, right?

@VladimirSlavik
Copy link
Contributor

We should no longer care about the options without inst. prefix, so I think this is fine as-is.

@VladimirSlavik
Copy link
Contributor

There is one more place where this might be removed, I think. If I got it right, the ignore list does not need dmraid anymore, because blivet no longer asks us to install it...?

https://github.com/rhinstaller/anaconda/blob/master/data/profile.d/rhel.conf#L21

VladimirSlavik
VladimirSlavik approved these changes Jan 20, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the question above, LGTM, thank you!

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

@vojtechtrefny
Remove the dmraid and nodmraid boot options
d79cf64 
These control the blivet dmraid flag which is being removed. We
are switching to mdadm for Firmware/BIOS RAID support in Fedora,
see https://fedoraproject.org/wiki/Changes/UseMdadmForBIOSRAIDInAnaconda
@vojtechtrefny
Copy link
Contributor Author

There is one more place where this might be removed, I think. If I got it right, the ignore list does not need dmraid anymore, because blivet no longer asks us to install it...?

https://github.com/rhinstaller/anaconda/blob/master/data/profile.d/rhel.conf#L21

Yes, that's right, I removed the package. Thanks.

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

poncovka
poncovka approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@poncovka
Copy link
Contributor

/kickstart-test --testtype smoke

@vojtechtrefny
Copy link
Contributor Author

The blivet PR is merged and I am doing a build for rawhide now so this can be merged too. The blivet build with the fix will be 3.6.1-3 but I don't think it's necessary to bump the required version in spec. And everything should still work fine without the Anaconda part so you don't need to do a new rawhide build right away.

@poncovka poncovka removed the blocked Don't merge this pull request! label Feb 2, 2023
@poncovka poncovka merged commit 0a97b81 into rhinstaller:master Feb 2, 2023
@VladimirSlavik VladimirSlavik removed the release note required Write a release note for this change. label May 15, 2023
mikhailnov added a commit to mikhailnov/anaconda that referenced this pull request Oct 4, 2023
@mikhailnov
Disable dmraid by default
86ba46d 
a.avdonin@ found that Anaconda fails to detect RAID unless "inst.nodmraid" is specified in the kernel cmdline.
Let's just follow upstream which dropped dmraid and disable it by default.
https://fedoraproject.org/wiki/Changes/UseMdadmForBIOSRAIDInAnaconda
rhinstaller#4517

See also: https://abf.io/import/libblockdev/commit/c86f5a0fd00fefc08f3e32054a69e4e3d337360f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poncovka poncovka poncovka approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees

@poncovka poncovka

Labels
f38 Fedora 38
Milestone
No milestone
3 participants
@vojtechtrefny @VladimirSlavik @poncovka