Add DNS search and ignore options from kickstart

[VladimirSlavik]

This is the anaconda part.

Blocked by waiting on pykickstart/pykickstart#431, which in turn is blocked by rhbz#1656662.

TODOs:

• pykickstart PR opened: Add DNS handling options to the network command pykickstart/pykickstart#431
• pykickstart PR merged (tests will work)
• pykickstart released (can merge)
• release notes
• testing
• add tests

[VladimirSlavik]

Tested manually to work OK.

Blocked on pykickstart merge and release.

[VladimirSlavik]

add tests

I don't think tests are actually needed. Pretty much none of the functions in the module have any :(

[rvykydal]

I think we should also include the option in generated kickstart:

anaconda/pyanaconda/modules/network/nm_client.py

Line 1474 in 3b964f1

def get_kickstart_network_data(connection, nm_client, network_data_class):

.

[rvykydal]

add tests

I don't think tests are actually needed. Pretty much none of the functions in the module have any :(

I wouldn't insist on adding them in scope of this PR. We should add a new issue for adding unit tests for nm-client.py. Or maybe adding a test for update_connection_ip_settings_from_ksdata in scope of this BZ could be a nice start.

Also we might want to add a kickstart test for the feature (or update an existing one but I didn't find any suitable in TESTTYPE="network" set). It would just do something like

check_device_config_value @KSTEST_NETDEV2@ DNS1 10.43.26.2 ipv4 dns "10.43.26.2;"

is done in https://github.com/rhinstaller/kickstart-tests/blob/eb975b25d14b75916bf2ea5d2c25af51080db305/network-autoconnections-httpks.ks.in#L100
A question is if we want a new test specific for this feature (having resources in mind); or if we use some existing, but a bit unrelated, one, like the network-autoconnections-httpks; or if we create some generic test for network options of similar nature. I'd maybe prefer the last option.

[VladimirSlavik]

Added the ks generation part, now (re-)testing manually

[VladimirSlavik]

Manual testing succeeded but needed rebasing ^

[VladimirSlavik]

Or maybe adding a test for update_connection_ip_settings_from_ksdata in scope of this BZ could be a nice start.

Sounds good to me.

[rvykydal]

Or maybe adding a test for update_connection_ip_settings_from_ksdata in scope of this BZ could be a nice start.

Sounds good to me.

Thank you, looks good to me so far. I'll wait for the tests and finish the review.

[VladimirSlavik]

The tests won't run without pykickstart, so I'd perhaps get that merged?

[rvykydal]

Looks good to me, thank you!

[VladimirSlavik]

No longer blocked by pykickstart at all, except for propagation to mirrors.

[VladimirSlavik]

/kickstart-test --testtype smoke

[rvykydal]

Looks good to me.