Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hub and spoke user account for Fedora Design Suite #4550

Merged
merged 0 commits into from Feb 14, 2023

Conversation

luyatshimbalanga
Copy link
Contributor

This commit removes hub and spoke user account to follow Workstation approach.

Thank you for your contribution!

@VladimirSlavik VladimirSlavik self-assigned this Feb 13, 2023
@VladimirSlavik VladimirSlavik added the f38 Fedora 38 label Feb 13, 2023
@VladimirSlavik
Copy link
Contributor

This will need extending tests. See eg. https://github.com/rhinstaller/anaconda/pull/3680/files for where to look. The tests might be slightly different these days, but once you know where to look, it's just copypasta and changing the strings to match your new config.

@poncovka poncovka temporarily deployed to releases February 14, 2023 04:55 — with GitHub Actions Inactive
@InStallker InStallker merged commit c769310 into rhinstaller:master Feb 14, 2023
@VladimirSlavik
Copy link
Contributor

What the bleep happened here?

@poncovka
Copy link
Contributor

poncovka commented Feb 14, 2023

So, this is my theory. I think that the fork uses the pull app to "keep the fork up-to-date". Then 8 hours ago, our workflow automatically created and pushed a release commit to our master branch. That triggered the pull app and caused a forced update of the master branch on the fork. Now the fun part. This pull request is not opened for a dedicated feature branch created on the fork, it is opened for the master branch on the fork. So after the actions of the pull app, this is basically our master branch. Therefore, "poncovka deployed to releases" and "InStallker merged commit" are statuses of our master branch. And since I was the last person who touched the implementation of the deployment workflow, GitHub uses my name in that status.

What does it mean? The changes in this pull request were dropped by the pull app, so they were not merged to our repository. You can see that this pull request has 0 commits now. @luyatshimbalanga, could you open a new pull request and use a dedicated feature branch or disable the pull app, please?

@VladimirSlavik
Copy link
Contributor

Thanks for the writeup - I agree that is the most probable explanation.

@luyatshimbalanga
Copy link
Contributor Author

I created another pull request with disabled pull app. See #4554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f38 Fedora 38
4 participants