Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nospacecheck argument to bypass space checking #472

Closed

Conversation

jkonecny12
Copy link
Member

Adding inst.nospacecheck boot option and --nospacecheck argument.

User still gets about the space needed but the installation could be started.

This is some kind of follow-up on space check patches.

Adding inst.nospacecheck boot option and --nospacecheck argument.

User still gets about the space needed but the installation could be
started.
@jkonecny12 jkonecny12 added the master Please, use the `f39` label instead. label Dec 14, 2015
@clumens
Copy link
Contributor

clumens commented Dec 16, 2015

Why do we need to do this? We've already got about a million command line options, very few of which ever see any testing. I think what's going to happen after this is you're going to get a bug from someone who used this option, didn't have enough space so anaconda failed, and is angry about anaconda providing them a way to shoot themselves in the foot.

@jkonecny12
Copy link
Member Author

Anaconda is using new space check now and it needs a little more space requirement then before. Still it's more precise and the installation shouldn't fail because of low space now.

Another reason is when user will use partitioning where most files will be installed to another partitions than /. Even when this installation could be installed with minimum size of the / mountpoint we still require the whole required size in root ( maybe root + usr I don't know right now) and we don't have enough information to create precise estimation for this. Disabling space check seems to me as nice way to solve this.

@jkonecny12
Copy link
Member Author

Anyone here who wants this boot option in anaconda? I'm going to close this PR if I'm the only one.

@vpodzime
Copy link
Contributor

vpodzime commented Jan 5, 2016

Anyone here who wants this boot option in anaconda? I'm going to close this PR if I'm the only one.

Do we have a real feature request for it?

@jkonecny12
Copy link
Member Author

I can't find anything on bugzilla so I think we don't have request for now.
So I'm going to keep this change for future and if someone shows up who would like this feature I'll create new PR for this patch.

For now closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master Please, use the `f39` label instead.
3 participants