Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated conf: kickstart_modules, addons_enabled #4764

Merged
merged 1 commit into from Jul 19, 2023
Merged

Drop deprecated conf: kickstart_modules, addons_enabled #4764

merged 1 commit into from Jul 19, 2023

Conversation

VladimirSlavik
Copy link
Contributor

SSIA.

@VladimirSlavik VladimirSlavik added notable change Important changes like API change, behavior change... f39 labels May 16, 2023
@VladimirSlavik
Copy link
Contributor Author

/kickstart-test --testtype smoke

@jstodola
Copy link
Contributor

jstodola commented May 16, 2023 •
edited

This removal should be coordinated with the Image builder folks, since osbuild uses kickstart_module:
https://github.com/osbuild/osbuild/blob/3343696a7b66316ca0ccfd936b12ca951d901eb7/stages/org.osbuild.anaconda#L37
See also https://bugzilla.redhat.com/show_bug.cgi?id=2023855#c5

@VladimirSlavik VladimirSlavik added the blocked Don't merge this pull request! label May 16, 2023
@VladimirSlavik
Copy link
Contributor Author

VladimirSlavik commented May 16, 2023 •
edited

Thanks for linking that, I was wondering where to talk to them...

edit: https://bugzilla.redhat.com/show_bug.cgi?id=2023855#c8 Set the blocked label until we resolve that.

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jul 16, 2023
@VladimirSlavik
Copy link
Contributor Author

Depends on osbuild/osbuild#1320

@VladimirSlavik VladimirSlavik removed the blocked Don't merge this pull request! label Jul 19, 2023
@VladimirSlavik VladimirSlavik merged commit 8b79b4f into rhinstaller:master Jul 19, 2023
22 checks passed
@VladimirSlavik VladimirSlavik deleted the master-remove-deprecated-conf branch July 19, 2023 10:25
@VladimirSlavik VladimirSlavik self-assigned this Jul 19, 2023
@rvykydal rvykydal mentioned this pull request Jul 20, 2023
Closed
@VladimirSlavik VladimirSlavik mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poncovka poncovka Awaiting requested review from poncovka

Assignees

@VladimirSlavik VladimirSlavik

Labels
f39 notable change Important changes like API change, behavior change...
Milestone
No milestone
2 participants
@VladimirSlavik @jstodola