Increment AnacondaWidgets version #489
Conversation
| @@ -61,7 +61,7 @@ lib_LTLIBRARIES = libAnacondaWidgets.la | |||
| libAnacondaWidgets_la_CFLAGS = $(GTK_CFLAGS) $(GLADEUI_CFLAGS) $(LIBXKLAVIER_CFLAGS) -Wall -g\ | |||
| -DWIDGETS_DATADIR=$(WIDGETSDATA) | |||
| libAnacondaWidgets_la_LIBADD = $(GTK_LIBS) $(GLADEUI_LIBS) $(LIBXKLAVIER_LIBS) | |||
| libAnacondaWidgets_la_LDFLAGS = $(LTLIBINTL) -version-info 3:1:1 | |||
| libAnacondaWidgets_la_LDFLAGS = $(LTLIBINTL) -version-info 3:2:1 | |||
There was a problem hiding this comment.
According to some slides about Autotools I have I think this change should be to 4:0:2
There was a problem hiding this comment.
Thank you for the explanation. I couldn't found it anywhere.
There was a problem hiding this comment.
https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html is the libtool documentation for -version-info. 4:0:2 is correct, since the change adds interfaces but does not remove or change existing ones.
jkonecny12
force-pushed
the
master-inc-widgets-version
branch
from
5b853fe
to
abee363
Compare
|
PR updated. Therefore AnacondaWidgets soname version is 4.0 and GI for them is also 4.0. I hope I understand it correctly now :D. |
|
The version in -version-info (4:0:2) is not necessarily connected to the widgets version (3.2/4.0). I think incrementing the widgets version to 3.3 instead of 4.0 would be better, since the changes are backwards compatible. |
|
Yeah I was thinking about that too but that looks to me bad when there are so many different versions of one piece of the software. It's still somehow crazy to me :D . I'll change the widgets version to 3.3 ( the AnacondaWidgets_3_3_gir_FILES too) and leave the soname version the same as it is (-version-info (4:0:2)). |
New version is now 3.3
New AnacondaWidgets version is 3.3
Anaconda GI now requires the AnacondaWidgets in version 3.3. It's required for the multiselection feature in the Custom spoke.
jkonecny12
force-pushed
the
master-inc-widgets-version
branch
from
abee363
to
6429b47
Compare
|
Updated. @dashea is it fine now? |
|
Looks good to me. |
|
Looks good to me too |
|
Pushed. Thank you for helping me. |
Follow-up for the #483 .