-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webui: use monospace font in critical error dialog #5033
webui: use monospace font in critical error dialog #5033
Conversation
@@ -36,6 +36,8 @@ import { ExternalLinkAltIcon } from "@patternfly/react-icons"; | |||
|
|||
import { exitGui } from "../helpers/exit.js"; | |||
|
|||
import "./Error.scss"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it also work by using the Patternfly pre solution? <Text component={TextVariants.pre}>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops does not look good. Sorry for wrong hint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. :)
/kickstar-test --testtype smoke |
/kickstart-test --testtype smoke |
This brings the fonts used in the dialog more in line with the mockup: #4942 (comment).
PR:
Current state: