Master uefi fix2 #512
Closed
Master uefi fix2 #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the proposed behavior should be okay for users. And the changes look good to me apart from the minor comments above. |
This approach changes the deleteAll behaviour as follows: * Partitions known to be shared with other OSes won't be deleted * Boot partitions won't be deleted if there are unknown parts You can delete these partitions only by specifically targeting them. It also adds a variant of the ConfirmDeleteDialog for boot partitions, with text specifically explaining that they might be needed for other OSes to boot. Based on the PR from AdamWill. His patch was reworked in order to apply because of multiselection feature which caused many changes in Custom spoke. Also add small fix in the original patch because pageTitle is not unique. This should be final fix for the UEFI shared partitions problem. Related: rhbz#1183880
When user click on any not-shared partition and check option Delete all it will remove all not-shared partitions from that page. If an user did this on shared partition it will remove all not-shared partitions in that page but it will also remove that selected partition (even when it's shared). To stay consistent use the same rule for the selected partition. Related: rhbz#1183880
jkonecny12
force-pushed
the
master-uefi-fix2
branch
from
78d326b
to
967259c
Compare
|
Updated. Thank you for review @vpodzime . |
|
Pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR #508 but rebased to actual master (there were some conflicts) and with new commit.
When user click on any not-shared partition and check option Delete all it will remove all not-shared partitions from that page.
If an user did this on shared partition it will remove all not-shared partitions in that page but it will also remove that selected partition (even when it's shared).
To stay consistent use the same rule for the selected partition.
I hope this will be good solution for all of you guys.
Related: rhbz#1183880