Widgets resources #523
Closed
Widgets resources #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to do that anymore. Switch the existing SGML to markdown. Besides being a goal in itself, dumping SGML lets us more easily continue to copy gtk for documentation templates.
guint is always pass by value, so there is no reference to transfer.
The various tools that consume these symbols assume that hyphens become underscores when a property or signal name needs to become an identifier, and having them start out as underscores throws them off. Also add more hyphens to the chosen-changed signal documentation comment to make gtk-doc happy.
|
Looks good to me. Thank you |
The resource bundle is automatically generated from whatever files are in widgets/src/resources. The GResource object is accessible by including resource.h and calling anaconda_widgets_get_resource(). The individual files are accessible under the path /org/fedoraproject/anaconda/widgets/<filename>.
This removes all public functions from widgets-common.c, so demote it to undocumented and non-introspected. This also removes the need for the ANACONDA_WIDGETS_DATA environment variable (and the associated test), since this way there is no filesystem location to override.
Provide names for the stylable internal widgets, and use CSS instead of Pango attributes and markup to set the style attributes. This allows the appearance of the anaconda widgets to be more easily modified by product-specific stylesheets. The new widget names are only applied to the leaf widgets (labels and buttons and such) since making the containers mess-with-able sounds like trouble, and the type and existence of the containers could change if we decide to switch to gadget types. As part of the changes for moving things to CSS, what looks like the intent of anaconda_mountpoint_selector_toggle_background (unselected selectors are gray, selected selectors are black) actually works now, and the incomplete state of AnacondaSpokeSelector is now tied to the inconsistent widget flag. The CSS data is stored in regular CSS files that get compiled into libAnacondaWidgets.so, since that seemed less gross than a bunch of multi-line C strings.
dashea
force-pushed
the
widgets-resources
branch
from
32c1d89
to
0a86dab
Compare
|
Fixed the issues revealed by the tests |
|
Still looks good to me :). |
|
Pushed to master and f24. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the master/f24 version of #518 plus a couple other things