-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try what happens if we drop the tiger-vnc dependency #5410
Conversation
/build-image --boot.iso |
Images built based on commit 80424f2:
Download the images from the bottom of the job status page. |
80424f2
to
628d121
Compare
And of course this can't be as simple as just removing the dependency in our spec file - Lorax also has it in its runtime templates! :P |
Drop the Tiger VNC package from Anaconda spec file. This by itself is actually not sufficient as for some reason Tiger VNC packages are also part of the Lorax templates (!). So to fully remove Tiger VNC, it is also necessary to remove it from the Lorax templates. Lastly, it looks like Tiger VNC is actually the only thing pulling in the mesa-dri-drivers (!!) packake, without which gnome-kiosk will crash at startup (!!!). So also add mesa-dri-drivers as a depndency of the Anaconda GUI package.
That should hopefully do it together with the Anaconda spec file change. FIXME: Temporary commit needed for testing and image generation purposes. Should not be part of the final PR before merging.
4ebc639
to
27e5649
Compare
Updated PR description to match latest findings. |
To summarize, a Tiger VNC removal should ideally also remove the code & possibly point the user to replacement options, if any, to avoid a bad UX. |
This PR is stale because it has been open 60 days with no activity. |
This PR was closed because it has been stalled for 30 days with no activity. |
Drop the tiger-vnc dependency
Drop the Tiger VNC package from Anaconda spec file.
This by itself is actually not sufficient as for some
reason Tiger VNC packages are also part of the Lorax templates (!).
So to fully remove Tiger VNC, it is also necessary to remove it
from the Lorax templates.
Lastly, it looks like Tiger VNC is actually the only thing pulling
in the mesa-dri-drivers (!!) packake, without which gnome-kiosk will
crash at startup (!!!). So also add mesa-dri-drivers as a depndency of
the Anaconda GUI package.