Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try what happens if we drop the tiger-vnc dependency #5410

Closed
wants to merge 2 commits into from

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented Jan 17, 2024

Drop the tiger-vnc dependency

Drop the Tiger VNC package from Anaconda spec file.

This by itself is actually not sufficient as for some
reason Tiger VNC packages are also part of the Lorax templates (!).

So to fully remove Tiger VNC, it is also necessary to remove it
from the Lorax templates.

Lastly, it looks like Tiger VNC is actually the only thing pulling
in the mesa-dri-drivers (!!) packake, without which gnome-kiosk will
crash at startup (!!!). So also add mesa-dri-drivers as a depndency of
the Anaconda GUI package.

@M4rtinK M4rtinK added the blocked Don't merge this pull request! label Jan 17, 2024
@github-actions github-actions bot added the f40 label Jan 17, 2024
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 17, 2024

/build-image --boot.iso

Copy link

Images built based on commit 80424f2:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 17, 2024

And of course this can't be as simple as just removing the dependency in our spec file - Lorax also has it in its runtime templates! :P

https://github.com/weldr/lorax/blob/master/share/templates.d/99-generic/runtime-install.tmpl#L134C1-L135C34

https://github.com/weldr/lorax/blob/master/share/templates.d/99-generic/runtime-cleanup.tmpl#L59C1-L59C38

Drop the Tiger VNC package from Anaconda spec file.

This by itself is actually not sufficient as for some
reason Tiger VNC packages are also part of the Lorax templates (!).

So to fully remove Tiger VNC, it is also necessary to remove it
from the Lorax templates.

Lastly, it looks like Tiger VNC is actually the only thing pulling
in the mesa-dri-drivers (!!) packake, without which gnome-kiosk will
crash at startup (!!!). So also add mesa-dri-drivers as a depndency of
the Anaconda GUI package.
That should hopefully do it together with the Anaconda spec file change.

FIXME: Temporary commit needed for testing and image generation
purposes. Should not be part of the final PR before merging.
@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 19, 2024

Updated PR description to match latest findings.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 25, 2024

Inf inst.vnc boot option is used, installation startup will be aborted with quite clear error message:
inst_vnc

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 26, 2024

So I have looked into what happens if also some of the other VNC related boot options are used:
inst_vncpassword
The inst.vncpassword boot option results in a crash and traceback. The end result is still the same, but it looks much more scary.

inst_vncconnect
inst.vncconnect behaves the same as inst.vnc, the installation is aborted without traceback.

As for kickstart, the results are similar:
ks_vnc
Just vnc in kickstart.

ks_password
Using vnc --password also causes a crash, like with the boot option.

@M4rtinK
Copy link
Contributor Author

M4rtinK commented Jan 26, 2024

To summarize, a Tiger VNC removal should ideally also remove the code & possibly point the user to replacement options, if any, to avoid a bad UX.

@KKoukiou KKoukiou added f41 and removed f40 labels Feb 29, 2024
Copy link

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Apr 30, 2024
Copy link

This PR was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Don't merge this pull request! f41 stale
2 participants