Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xrandr and xrdb removal #5470

Merged
merged 2 commits into from
Jun 6, 2024
Merged

xrandr and xrdb removal #5470

merged 2 commits into from
Jun 6, 2024

Conversation

jexposit
Copy link
Contributor

Both tools are X11 only.

Replace xrandr with Mutter's API and remove xrdb as it is not used.

@jexposit jexposit added blocked Don't merge this pull request! rhel-10 labels Feb 14, 2024
@github-actions github-actions bot added the f40 label Feb 14, 2024
@jexposit jexposit removed the f40 label Feb 14, 2024
@M4rtinK
Copy link
Contributor

M4rtinK commented Feb 16, 2024

/build-image --boot.iso --live

@github-actions GitHub Actions
Copy link

Images built based on commit d56cff8:

  • boot.iso: failure

  • Live: failure

Download the images from the bottom of the job status page.

@M4rtinK
Copy link
Contributor

M4rtinK commented Feb 16, 2024

/build-image --boot.iso --live

@github-actions GitHub Actions
Copy link

Images built based on commit d56cff8:

  • boot.iso: success

  • Live: success

Download the images from the bottom of the job status page.

M4rtinK
M4rtinK approved these changes Feb 19, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple smaller suggestions. :)

pyanaconda/mutter_display.py Outdated Show resolved Hide resolved
pyanaconda/mutter_display.py Show resolved Hide resolved
pyanaconda/mutter_display.py Show resolved Hide resolved
pyanaconda/mutter_display.py Outdated Show resolved Hide resolved
@Conan-Kudo
Copy link
Contributor

Could we make this into a tool instead? This would be very useful for regular folks too using GNOME.

@jexposit
Copy link
Contributor Author

@Conan-Kudo there is a tool that does something similar. GNOME only:

https://github.com/jadahl/gnome-monitor-config/

@Conan-Kudo
Copy link
Contributor

Could we package that and have Anaconda use it instead?

@jexposit
Copy link
Contributor Author

It is already packaged for Fedora:
https://src.fedoraproject.org/rpms/gnome-monitor-config/

However, I don't think it is a good idea to use this tool. We would have to parse the output of gnome-monitor-config list to find the right configuration to use with set. Any change in the tool output could break our parser.

I think that using the D-Bus API, which is supposed to be stable, is a better option in this case.

@jexposit
Copy link
Contributor Author

/build-image --boot.iso --live

@github-actions GitHub Actions
Copy link

Images built based on commit e2c0115:

  • boot.iso: success

  • Live: failure

Download the images from the bottom of the job status page.

@jexposit jexposit mentioned this pull request Feb 21, 2024
Merged
@jexposit jexposit mentioned this pull request Mar 4, 2024
Closed
@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 9, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-fedora,gh576,gh595,gh640,gh641,gh680,gh740,gh769,gh774,gh777,gh910,gh890,gh871,rhbz1853668,gh975,gh1023

@packit-as-a-service Packit-as-a-Service
Copy link

Failed to load packit config file:

Cannot parse package config. TypeError("'NoneType' object is not iterable")

For more info, please check out the documentation or contact the Packit team. You can also use our CLI command validate-config or our pre-commit hooks for validation of the configuration.

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 15, 2024

/kickstart-test --testtype smoke

rvykydal
rvykydal reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I wonder if we want to add unit tests for the MutterDisplay class.

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 25, 2024

/build-image --boot.iso

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 25, 2024

/kickstart-test --testtype smoke

@github-actions GitHub Actions
Copy link

Images built based on commit a56c000:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 26, 2024

/build-image --boot.iso

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 26, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-fedora,gh576,gh595,gh640,gh641,gh680,gh740,gh769,gh774,gh777,gh910,gh890,gh871,rhbz1853668,gh975,gh1023

@github-actions GitHub Actions
Copy link

Images built based on commit 99ba7e5:

  • boot.iso: success

Download the images from the bottom of the job status page.

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 26, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-rhel,skip-on-rhel-10,gh576,gh640,gh804,gh1090,gh1104,gh1106,gh1105,gh1108,gh1109,gh1107,gh1110

@M4rtinK
Copy link
Contributor

M4rtinK commented Apr 30, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-rhel,skip-on-rhel-10,gh576,gh640,gh804,gh1090,gh1104,gh1106,gh1105,gh1108,gh1109,gh1107,gh1110

1 similar comment
@M4rtinK
Copy link
Contributor

M4rtinK commented May 3, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-rhel,skip-on-rhel-10,gh576,gh640,gh804,gh1090,gh1104,gh1106,gh1105,gh1108,gh1109,gh1107,gh1110

@M4rtinK M4rtinK mentioned this pull request May 16, 2024
Merged
@M4rtinK
Copy link
Contributor

M4rtinK commented May 22, 2024

Rebased on latest RHEL 10 branch & dropped the adwaita-icon-theme and gnome-kiosk package rebuilds from the COPR. Lets see if everything still works with latest RHEL 10 repo.

@M4rtinK
Copy link
Contributor

M4rtinK commented May 22, 2024

/kickstart-test --testtype smoke

jkonecny12
jkonecny12 approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

pyanaconda/core/regexes.py Outdated Show resolved Hide resolved
@M4rtinK
Copy link
Contributor

M4rtinK commented May 27, 2024

Rebased PR on latest rhel-10 branch & added correct Jira references. Also dropped python-pam from the temporary COPR repo, as it should be finally in the RHEL 10 repos.

@M4rtinK
Copy link
Contributor

M4rtinK commented May 28, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-rhel,skip-on-rhel-10,gh576,gh640,gh804,gh1090,gh1104,gh1106,gh1105,gh1108,gh1109,gh1107,gh1110

@M4rtinK
Copy link
Contributor

M4rtinK commented May 29, 2024

Kickstart test run looks very good - 206 successful tests & one (initial-setup-default failed) with an unrelated error (storage race condition ?):

pyanaconda.modules.common.errors.configuration.StorageConfigurationError: resource to create this format lvmpv is unavailable

@M4rtinK
Copy link
Contributor

M4rtinK commented May 29, 2024

/kickstart-test --skip-testtypes knownfailure,manual,skip-on-rhel,skip-on-rhel-10,gh576,gh640,gh804,gh1090,gh1104,gh1106,gh1105,gh1108,gh1109,gh1107,gh1110

@jexposit @M4rtinK
Drop xrandr
8b94761 
Anaconda uses xrandr to set the screen resolution when the boot option
"inst.resolution" [1] is used.

In order to be able to drop the X.Org server, use Mutter's API instead
of xrandr.

The kickstart equivalent option has been removed, so we don't need to
care about it [2].

[1] https://anaconda-installer.readthedocs.io/en/latest/boot-options.html#inst-resolution
[2] https://pykickstart.readthedocs.io/en/latest/kickstart-docs.html#xconfig

Resolves: RHEL-38399
@jexposit @M4rtinK
Drop xrdb
846dbde 
It wasn't used and it won't work on Wayland.

Resolves: RHEL-38399
@M4rtinK
Copy link
Contributor

M4rtinK commented Jun 6, 2024

/kickstart-test --testtype smoke

@M4rtinK M4rtinK merged commit 57bb6f8 into rhinstaller:rhel-10 Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@rvykydal rvykydal rvykydal left review comments

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
rhel-10
Milestone
No milestone
5 participants
@jexposit @M4rtinK @Conan-Kudo @rvykydal @jkonecny12