gui:Fix index error for _remove_treeinfo_repositories() #5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _remove_treeinfo_repositories() try to remove treeinfo repositories from _repo_store[],the index 'path' is saved in removal_repo_list[] and arranged in order. The problem is that _remove_repository(path) will remove the previous repositories,and the subsequent loops will get a wrong index for _repo_store[]. Fix it by reversing the removal_repo_list[], to secure previous repositories will not be removed before _remove_repository().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _remove_treeinfo_repositories() try to remove treeinfo repositories from _repo_store[],the index 'path' is saved in removal_repo_list[] and arranged in order.
The problem is that _remove_repository(path) will remove the previous repositories,and the subsequent loops will get a wrong index for _repo_store[].
Fix it by reversing the removal_repo_list[], to secure previous repositories will not be removed before _remove_repository().