Fix bad sensitivity on boxes in source spoke (#1262833) #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkonecny12
force-pushed
the
rhel7-fix-source-sensitivity
branch
from
8d73726
to
811eb3d
Compare
|
I think all the boxes should be made insensitive first and then one of the radio buttons should be activated ("clicked from code"). |
jkonecny12
force-pushed
the
rhel7-fix-source-sensitivity
branch
from
811eb3d
to
a422592
Compare
|
I completely reworked this patch. I think this is happening because we are setting up default value. I tried test with network, iso repo and without repo and it looks it works correctly now. |
Remove default sensitivity on Network box. It caused more gtk boxes were sensitive in one time. Enable network button when we have functional connectivity. Reported-by: Pavel Holica <pholica@redhat.com> Resolves: rhbz#1262833
jkonecny12
force-pushed
the
rhel7-fix-source-sensitivity
branch
from
a422592
to
d47ab19
Compare
|
Updated again. I hope I fixed the root cause of this problem now. |
|
Looks good to me. |
|
Pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boxes sensitivity for source types are changed when user clicks on radio button to change type of source.Fix problem when user enter source spoke -> nothing were clicked and everything is sensitive.
EDIT:
Remove default sensitivity on Network box. It caused more gtk boxes were sensitive in one time.
Enable network button when we have functional connectivity.
Reported-by: Pavel Holica pholica@redhat.com
Resolves: rhbz#1262833
I don't know why but it doesn't happened on rawhide/f24 so this is rhel7 only.