Add reason when logging invalid repository (#1240379) #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log.error("base repo (%s/%s) not valid -- removing it", | ||
| method.method, url) | ||
| log.error("base repo (%s/%s) not valid -- removing it\nreason: %s", | ||
| method.method, url, e) |
There was a problem hiding this comment.
The \n in there is going to mess up how the logs look. either log it as a separate line, or "-- removing it because: %s"
Also print exception message what caused the repository removal. Resolves: rhbz#1240379
jkonecny12
force-pushed
the
rhel7-rfe-inteligent-logging
branch
from
67c0d3a
to
3b2fb8f
Compare
|
Updated. |
|
Pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print also exception message which caused the repository removal.
Resolves: rhbz#1240379