Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: do not crash on destroyed device object in GUI #5544

Merged
merged 1 commit into from
Apr 12, 2024
Merged

network: do not crash on destroyed device object in GUI #5544

merged 1 commit into from
Apr 12, 2024

Conversation

rvykydal
Copy link
Contributor

Port of #5482

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

jkonecny12
jkonecny12 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Apr 10, 2024
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype network --skip-testtypes=gh576,gh595,rhbz1960279,gh641,gh774,gh790,gh970

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype network --skip-testtypes=gh576,gh595,rhbz1960279,gh641,gh774,gh790,gh970

The tests passed, the only failure stage2-from-ks fails in our daily tests as well since yesterday.

M4rtinK
M4rtinK approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. :)

@KKoukiou KKoukiou merged commit c813c72 into rhinstaller:rhel-9 Apr 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
Milestone
No milestone
4 participants
@rvykydal @M4rtinK @jkonecny12 @KKoukiou