Fix only one address is shown in anaconda (#1264400) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only NMIP[4,6]Config object was connected to signal on change. But when inner objects (Addresses, Nameservers, Gateway) changed it doesn't notify us about this change. Fix by connecting this inner properties too. Resolves: rhbz#1264400 Reported-by: Marek Hruscak <mhruscak@redhat.com>
jkonecny12
force-pushed
the
rhel7-fix-show-only-1-addr
branch
from
ead8f92
to
510f00d
Compare
|
Looks good to me. |
|
Pushed to rhel7, it seems it must be changed to master. So I'm closing this PR and I'm going to create new for the master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only
NMIP[4,6]Configobject was connected to signal on change. But when inner objects (Addresses, Nameservers, Gateway) changed it doesn't notify us about this change.Fix by connecting this inner properties too.
Resolves: rhbz#1264400
Reported-by:
Marek Hruscak <mhruscak@redhat.com>