Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rhel10 guard teamd functionality #5567

Merged
merged 3 commits into from
Apr 24, 2024
Merged

Rhel10 guard teamd functionality #5567

merged 3 commits into from
Apr 24, 2024

Conversation

rvykydal
Copy link
Contributor

Port from Fedora.

@pep8speaks
Copy link

pep8speaks commented Apr 16, 2024 •
edited

Hello @rvykydal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 43:1: E402 module level import not at top of file

Comment last updated at 2024-04-23 09:43:16 UTC

@rvykydal rvykydal mentioned this pull request Apr 16, 2024
Merged
M4rtinK
M4rtinK approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal
network: add Capabilities property to API
65ee141 
Read-only property informing about network capabilities supported by
backend. It is using NetworkManager capabilities API and currently is
limited to team capability.

Related: INSTALLER-3945
@rvykydal
network gui: use Capabilites API to guard adding of team device
ed66381 
Resolves: INSTALLER-3945
@rvykydal rvykydal force-pushed the rhel10-guard-teamd-functionality branch from d1b4cf0 to c7ec8c5 Compare April 23, 2024 09:33
@rvykydal rvykydal force-pushed the rhel10-guard-teamd-functionality branch from c7ec8c5 to 1f975f4 Compare April 23, 2024 09:43
@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

@rvykydal
Copy link
Contributor Author

/kickstart-test --waive broken

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Apr 23, 2024
@KKoukiou KKoukiou merged commit ea08068 into rhinstaller:rhel-10 Apr 24, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
Milestone
No milestone
5 participants
@rvykydal @pep8speaks @M4rtinK @jkonecny12 @KKoukiou