Multiple Dogtail tests improvements #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atodorov
force-pushed
the
gui_tests_rewrite
branch
from
4f7c0d6
to
8cecafb
Compare
|
Ping, any updates here ? Btw the CantReclaimTestCase fails b/c there is no more "No Space" dialog present. The user is left with the option to reclaim disk space, although the entire disk size is smaller that what is required to install the selected package set. Is this intentional ? |
| # Tests will click the Reboot or Quit button which will shutdown anaconda. | ||
| # We need to make sure /mnt/sysimage/* are unmounted and device mapper devices | ||
| # are removed before starting the next test. | ||
| subprocess.call(["%s/scripts/anaconda-cleanup" % os.environ.get("top_srcdir", "")], |
There was a problem hiding this comment.
If $top_srcdir isn't set, this will mean /scripts/anaconda-cleanup will get run. You probably want ./scripts/anaconda-cleanup to get run instead. So:
os.environ.get("top_srcdir", ".")
- use unittest.skipIf and execute via nosetests_root.sh - remove support for anacondaArgs because it was not used - screenshots are placed in the correct test results directory - logs are collected on test failures too - cleanup mounted filesystems and update anaconda-cleanup to use the new BlockDev loop plugin along the way
atodorov
force-pushed
the
gui_tests_rewrite
branch
from
8cecafb
to
0d8f86d
Compare
|
Merged manually, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the new BlockDev loop plugin along the way
This is in order to add these tests to make ci. The CI environment only needs X display configured and accessibility enabled.