Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL-10: Update workflows from master #5627

Merged
merged 3 commits into from
May 20, 2024

Conversation

jkonecny12
Copy link
Member

This will fix currently failed tests on outdated workflow failing on PRs to rhel-10 branch.

@github-actions github-actions bot added infrastructure Changes affecting mostly infrastructure rhel-10 labels Apr 30, 2024
@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

Copy link

github-actions bot commented May 2, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

branch-config.mk.j2

Copy link

github-actions bot commented May 2, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

Copy link

github-actions bot commented May 2, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@KKoukiou KKoukiou marked this pull request as ready for review May 3, 2024 06:51
@KKoukiou
Copy link
Contributor

KKoukiou commented May 3, 2024

/kickstart-tests --waive infra only

1 similar comment
@KKoukiou
Copy link
Contributor

KKoukiou commented May 3, 2024

/kickstart-tests --waive infra only

@KKoukiou KKoukiou closed this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@KKoukiou KKoukiou reopened this May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@KKoukiou
Copy link
Contributor

KKoukiou commented May 3, 2024

/kickstart-test --testtype smoke

Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@jkonecny12
Copy link
Member Author

Looks good to me I'm just not sure if we are ready with the -1 suffix removal.

Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@KKoukiou
Copy link
Contributor

KKoukiou commented May 3, 2024

Looks good to me I'm just not sure if we are ready with the -1 suffix removal.

Without the -1 removal - we need to remove also the changes to the packit file - which is actually enforced because it's a template.

Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

Makefile.am
anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@jkonecny12
Copy link
Member Author

I see, in that case feel free to go with this.

@jkonecny12
Copy link
Member Author

/kickstart-test --testtype smoke

@KKoukiou
Copy link
Contributor

KKoukiou commented May 3, 2024

/kickstart-test --waive infra only

Copy link

github-actions bot commented May 3, 2024

Infrastructure check failed on these files. Please do a double check of these files before merge!

anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

jkonecny12 and others added 3 commits May 20, 2024 15:08
We removed release from makebumpver already in the previous commit
3ae1964 , however, this wasn't so
radical change and introduced a bug. Let's go by force and remove
relase number from the makebumper script completely.

This should fix the releasing, however, first version released with this
change will be incorrect and should be handled manually. Reason is
that with this change we expect all the previous releases to be without
the release number.
Copy link

Infrastructure check failed on these files. Please do a double check of these files before merge!

anaconda.spec.in
branch-config.mk.j2
scripts/makeupdates

@KKoukiou
Copy link
Contributor

/kickstart-tests --waive infra only

@KKoukiou KKoukiou added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label May 20, 2024
@KKoukiou KKoukiou merged commit ff34ee6 into rhinstaller:rhel-10 May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Changes affecting mostly infrastructure ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-10
2 participants