Rerun writeBootLoader on Live BTRFS installs #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support installation of live media without an initramfs (to save space) this reruns writeBootLoader for all live BTRFS installations. This will also fix the missing initrd line when /boot is on BTRFS (see rhbz#1200539). Without this the initial grub2-mkconfig without an initramfs doesn't build the kernel cmdline correctly. On live installations the initramfs is always rebuilt, but that happens after the initial call to writeBootLoader.
| # This works around 2 problems, /boot on BTRFS and BTRFS installations where the initrd is | ||
| # recreated after the first writeBootLoader call. This reruns it after the new initrd has | ||
| # been created, fixing the kernel root and subvol args and adding the missing initrd entry. | ||
| boot_on_btrfs = isinstance(storage.mountpoints.get("/"), BTRFSDevice) |
There was a problem hiding this comment.
What if / is not a BTRFSDevice, but /boot is? (if we support something like that)
I don't think that's possible, or likely. I'm also pretty sure we're currently not supporting /boot on btrfs because of the previous issues. |
Works for me. |
|
Pushed to master only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support installation of live media without an initramfs (to
save space) this reruns writeBootLoader for all live BTRFS
installations. This will also fix the missing initrd line when
/boot is on BTRFS (see rhbz#1200539).
Without this the initial grub2-mkconfig without an initramfs doesn't
build the kernel cmdline correctly. On live installations the initramfs
is always rebuilt, but that happens after the initial call to
writeBootLoader.