Stop using undocumented DNF logging API #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DNF doesn't want users to access base.logging anymore. This changes the dnf logging so that the dnf and dnf.rpm loggers go into packaging.log now. It preserves the dnf.librepo.log file and the hawkey.log files so that they can be examined after the installation is complete or crashes.
| @@ -179,6 +179,13 @@ def __init__(self): | |||
| autoLevel=True) | |||
| self.forwardToSyslog(packaging_logger) | |||
|
|
|||
| # Create the dnf logger and link it to packaging | |||
| dnf_logger = logging.getLogger("dnf") | |||
| dnf_logger.setLevel(logging.DEBUG) | |||
There was a problem hiding this comment.
Any reason why we are using a different log level than in lorax here?
|
Looks good to me. |
|
Pushed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNF doesn't want users to access base.logging anymore.
This changes the dnf logging so that the dnf and dnf.rpm loggers go into
packaging.log now. It preserves the dnf.librepo.log file and the
hawkey.log files so that they can be examined after the installation is
complete or crashes.