Apply replacement of DNF deprecated method #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dnf.callback.LoggingTransactionDisplay` is deprecated now. It was considered part of API despite the fact that it has never been documented. Use `dnf.callback.TransactionProgress` instead.
Method for progress reporting is now named progress instead of event. Use a new method for error reporting to raise an exception when installation failed.
|
Looks good to me. |
|
I think that there should be no problem from dnf side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is taken from PR #740 .
Add fix on top of this commit and change the installation progress loop to more readable code.