Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct deviceLinks to device_links (blivet renamed it) #848

Merged
merged 1 commit into from Oct 31, 2016
Merged

Correct deviceLinks to device_links (blivet renamed it) #848

merged 1 commit into from Oct 31, 2016

Conversation

AdamWill
Copy link
Contributor

In 4e8f941b , blivet renamed the deviceLinks attribute of
StorageDevice and its subclasses to device_links. These
uses of it were never updated. The iSCSI one causes anaconda to
crash when logging into an iSCSI target; the other one probably
breaks something as well, but I don't know what.

Needed on master and f25.

@AdamWill
Correct deviceLinks to device_links (blivet renamed it)
b59d594 
In 4e8f941b , blivet renamed the `deviceLinks` attribute of
`StorageDevice` and its subclasses to `device_links`. These
uses of it were never updated. The iSCSI one causes anaconda to
crash when logging into an iSCSI target; the other one probably
breaks something as well, but I don't know what.
@jkonecny12
Copy link
Member

Jenkins, it's ok to test.

@jkonecny12 jkonecny12 added master Please, use the `f39` label instead. f25 labels Oct 27, 2016
jkonecny12
jkonecny12 approved these changes Oct 27, 2016
View reviewed changes
Copy link
Member

@jkonecny12 jkonecny12 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are still leftovers from the move of Blivet to Pep 8 naming. Unfortunately Pylint can't catch those on many places :(.

Thank you for finding them.

@vpodzime
Copy link
Contributor

Still don't understand WTH pylint is doing with these things. Or more precisely what it is not doing with them.

vpodzime
vpodzime approved these changes Oct 27, 2016
View reviewed changes
Copy link
Contributor

@vpodzime vpodzime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@jkonecny12 jkonecny12 merged commit 630d79e into rhinstaller:f25-devel Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpodzime vpodzime vpodzime approved these changes

@jkonecny12 jkonecny12 jkonecny12 approved these changes

Assignees
No one assigned
Labels
f25 master Please, use the `f39` label instead.
Milestone
No milestone
3 participants
@AdamWill @jkonecny12 @vpodzime