Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct deviceLinks to device_links (blivet renamed it) #848

Merged
merged 1 commit into from Oct 31, 2016

Conversation

Projects
None yet
3 participants
@AdamWill
Copy link
Contributor

commented Oct 27, 2016

In 4e8f941b , blivet renamed the deviceLinks attribute of
StorageDevice and its subclasses to device_links. These
uses of it were never updated. The iSCSI one causes anaconda to
crash when logging into an iSCSI target; the other one probably
breaks something as well, but I don't know what.

Needed on master and f25.

Correct deviceLinks to device_links (blivet renamed it)
In 4e8f941b , blivet renamed the `deviceLinks` attribute of
`StorageDevice` and its subclasses to `device_links`. These
uses of it were never updated. The iSCSI one causes anaconda to
crash when logging into an iSCSI target; the other one probably
breaks something as well, but I don't know what.
@jkonecny12

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2016

Jenkins, it's ok to test.

@jkonecny12
Copy link
Contributor

left a comment

These are still leftovers from the move of Blivet to Pep 8 naming. Unfortunately Pylint can't catch those on many places :(.

Thank you for finding them.

@vpodzime

This comment has been minimized.

Copy link
Contributor

commented Oct 27, 2016

Still don't understand WTH pylint is doing with these things. Or more precisely what it is not doing with them.

@vpodzime
Copy link
Contributor

left a comment

Looks good to me too.

@jkonecny12 jkonecny12 merged commit 630d79e into rhinstaller:f25-devel Oct 31, 2016

1 check failed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.