Filter spoke fixes and improvements #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This alphabetizes the properties, removes some properties that are equal to the default value, adds some empty placeholders, and adds the internal selection child for a tree view.
This makes the combo box usage not dependent on the combo box order and makes it all look a little less mysterious.
Search by Port / Target / LUN was usually returning an empty list since the port test was failing to compare a string to an int. Beyond that, do not return entries with no port when a port is selected, and do not return iscsi entries when a non-integer LUN is entered. Add an empty entry to all of the filter combo boxes so that the combo box criterion can be cleared. Replace a builder.get_object call with the already gotten object reference.
Set no_show_all=True, can_focus=False, and show_border=False for each of the search type notebooks. Set headers_clickable=False on the otherTreeView. Replace the stock gtk-find button on the other tab with a regularly labelled button. Add a translation context to the refresh button. Set a spacing of 5 in one of the boxes to 6. Fix the mnemonic_widget for the multipath filter label. Add a mnemonic_widget to the zFCP filter label. Remove an extra er from otherIDRenderer.
Two of the vendor columns had the diskMutable column set to yalign, which was probably doing something pretty weird.
Move the scrolled window on each filter page to be a parent of the TreeView instead of the parent of the whole page. This way the placement of the search widgets does not depend on the width of the tree view, and the TreeView can handle scrolling better without the intermediate viewport. Replace the grid on each page with nested boxes so that the various expansion rules make more sense.
Just search as the search parameters change. Use timed_action with a largeish delay to allow someone to finish typing or set several parameters at a time before running the search. Don't set busy_cursor since it doesn't switch back until the animation has done a full revolution, and the search is usually finished well before then.
|
These all look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd also like to port at least the first 6 to rhel7-branch