Don't crash if the UIC file can't be written (#1375702) #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't crash if the user interaction config file can't be written, which can happen for example on Atomic (read-only rootfs by default). Print and error message and log the exception instead.
vpodzime
approved these changes
Nov 18, 2016
| f.write(self._get_new_config_header()) | ||
| self._config.write(f) | ||
| except OSError: | ||
| log.exception("Can't write user interaction config file.") |
There was a problem hiding this comment.
Shouldn't this be a warning instead?
There was a problem hiding this comment.
The open() can generate quite a lot of various exceptions - so the general idea is to for now just to prevent the crash & log the exception. Later on (and possibly once we have more data) we can narrow down the scope of the except clause & log specific warnings/errors.
There was a problem hiding this comment.
Sounds good to me, but shouldn't this also log details about the exception then? Or does log.exception() do that somehow?
There was a problem hiding this comment.
Yep - log.exception() logs the message you give it and then the full traceback from the exception caught by the except block. From the docs:
Logger.exception(msg, *args, **kwargs)
Logs a message with level ERROR on this logger.
The arguments are interpreted as for debug().
Exception info is added to the logging message.
This method should only be called from an exception handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't crash if the user interaction config file can't be written,
which can happen for example on Atomic (read-only rootfs by default).
Print and error message and log the exception instead.