rpmostreepayload: Rework binds to be recursive #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our hardcoded list of mount points missed critical ones like `/sys/firmware/efi/efivars`, which broke installation on EFI. I started to add that to the list, but then I realized there's a much simpler solution - make the binds recursive and let `mount` do the work for us. This is a bit more risky of a change, but it'll clearly be more maintainable long term. Down the line...we may want to simply walk over all the toplevel mount points in `/mnt/sysimage`, but I doubt anyone is going to add anything new that's not a subdirectory of `/sys`. See https://pagure.io/atomic-wg/issue/185 Related: https://github.com/rhinstaller/anaconda/issues/900
cgwalters
force-pushed
the
rpmostree-efi
branch
from
2d1fb8b
to
543e100
Compare
|
Here's an |
|
Jenkins, it's ok to test. |
|
Looks good to me. |
|
can we get this merged? - we'd like to get things fixed so our next two week release of Atomic Host has a fix for this. |
|
can we get this merged in for f25 and cut a new rpm for Fedora? |
Closed
cgwalters
added a commit
to cgwalters/anaconda
that referenced
this pull request
Jul 12, 2017
In rhinstaller#903 we changed all of rpmostreepayload's internal mounts to be recursive to fix `/boot/efi`. And indeed all should be recursive, except one - the `/sysroot` mount. By asking for that to be recursive we've created a loop. I noticed a while ago that the output of `findmnt` during an install was insane (the deployment directory was visible twice, etc.), but never debugged it. It turns out this was the cause. Fixing this makes the mounts look a lot more sane, and will help for future work I have for `/var` mounts.
cgwalters
added a commit
to cgwalters/anaconda
that referenced
this pull request
Jul 12, 2017
In rhinstaller#903 we changed all of rpmostreepayload's internal mounts to be recursive to fix `/boot/efi`. And indeed all should be recursive, except one - the `/sysroot` mount. By asking for that to be recursive we've created a loop. I noticed a while ago that the output of `findmnt` during an install was insane (the deployment directory was visible twice, etc.), but never debugged it. It turns out this was the cause. Fixing this makes the mounts look a lot more sane, and will help for future work I have for `/var` mounts.
cgwalters
added a commit
to cgwalters/anaconda
that referenced
this pull request
Jul 24, 2017
In rhinstaller#903 we changed all of rpmostreepayload's internal mounts to be recursive to fix `/boot/efi`. And indeed all should be recursive, except one - the `/sysroot` mount. By asking for that to be recursive we've created a loop. I noticed a while ago that the output of `findmnt` during an install was insane (the deployment directory was visible twice, etc.), but never debugged it. It turns out this was the cause. Fixing this makes the mounts look a lot more sane, and will help for future work I have for `/var` mounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our hardcoded list of mount points missed critical ones
like
/sys/firmware/efi/efivars, which broke installationon EFI.
I started to add that to the list, but then I realized there's a much
simpler solution - make the binds recursive and let
mountdo thework for us. This is a bit more risky of a change, but it'll
clearly be more maintainable long term.
Down the line...we may want to simply walk over all the toplevel mount
points in
/mnt/sysimage, but I doubt anyone is going to add anythingnew that's not a subdirectory of
/sys.See https://pagure.io/atomic-wg/issue/185