Fix translations for EULA spoke related strings #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two strings that were not translated due to wrong translation context - the Licensing category name and the EULA spoke status message. In both cases the strings were just marked for translation with N_() only to be translated with _() from Anaconda with the "anaconda" context instead of the correct context of "initial-setup" or translated with _() imported from Anaconda. For the category name, just switch to Initial Setup localization module and translate the category name directly. For the EULA spoke title, use workaround similar to one used by the OSCAP addon - see bug 1673071 for more details. Resolves: rhbz#1814952
M4rtinK
force-pushed
the
rhel8-branch-fix_translation
branch
from
f7baf7a
to
d15cfe8
Compare
|
So this is how it looked before (licensing related strings are not translated): This is how the fixed screen looks like: |
VladimirSlavik
approved these changes
Sep 23, 2020
poncovka
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two strings that were not translated due to
wrong translation context - the Licensing category name
and the EULA spoke status message. In both cases the strings
were just marked for translation with N_() only to be translated
with _() from Anaconda with the "anaconda" context instead of
the correct context of "initial-setup" or translated with _()
imported from Anaconda.
For the category name, just switch to Initial Setup localization module
and translate the category name directly.
For the EULA spoke title, use workaround similar to one used
by the OSCAP addon - see bug 1673071 for more details.
Resolves: rhbz#1814952