Add a systemd generator that automatically launches IS if trigger file is found #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ists (#1257624) Add a systemd service called initial-setup-reconfiguration.service that automatically starts initial-setup.service when a file named .unconfigured exists in filesystem root (/). Initial Setup will then detect the file & start in the reconfiguration mode. Initial Setup also makes sure to delete the file & disable its service once done. Resolves: rhbz#1257624
Related: rhbz#1257624
| @@ -113,11 +121,26 @@ def __init__(self, gui_mode): | |||
| setup_ifcfg_log() | |||
|
|
|||
| @property | |||
| def external_reconfig(self): | |||
There was a problem hiding this comment.
But I don't see the point of making this @Property and having it just mirror the self._external_reconfig, it isn't actually doing anything more than a plain old attribute would.
There was a problem hiding this comment.
Well, I think it is still beneficial due to being able to attach a proper docstring to it.
|
Looks good other than the one comment. |
|
Pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch adds the initial-setup-reconfiguration.service which starts initial-setup.service if /.unconfigured exists.
The IS-side machinery then runs it in the reconfig mode due to the /.unconfigured trigger file being found. It also takes care of enabling of cleaning up the trigger file once done.
The second patch is just some cleanups and logging improvements I did when working on the first patch.
BTW, for this to work the initial-setep-reconfiguration.service needs to be always enabled.That effectively means the service needs to be added to the systemd presets file to assure it is automatically enabled when the initial-setup package is installed.