Add support to disable concurrency check #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now it is possible to disable concurrency check for InputHandler. However, this class is created on demand in the InputManager used by the UIScreen which means that a users are not able to disable concurrency_check without re-implementation of the InputManager and InputHandler which is really cumbersome. To solve this I'm adding a new property to InputManager and enable obtaining the InputManager instance from the UIScreen. The concurrency check shouldn't be disabled if you don't have a strong reason to do it. It was implemented because without the check it's really hard to debug when multiple screens are asking for the input at once. The main reason to disable it is for error reporting after the application has crashed. Resolves: rhbz#2134889 (cherry picked from commit e3ecece)
This small change is done to simplify testing of the code. Related: rhbz#2134889 (cherry picked from commit f0d8966)
Related: rhbz#2134889 (cherry picked from commit 741ae90)
jkonecny12
force-pushed
the
1.8-add-disable-concurrency-check
branch
from
59b4d9e
to
c888613
Compare
|
Rebased |
VladimirSlavik
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #111 .