Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Joint limits searched for in wrong assembly #77

Open
rsinnet opened this issue Jul 4, 2022 · 1 comment
Open

Joint limits searched for in wrong assembly #77

rsinnet opened this issue Jul 4, 2022 · 1 comment

Comments

@rsinnet
Copy link
Contributor

rsinnet commented Jul 4, 2022

During initial feature loading, a request is made to the Onshape API, but this request can be on the wrong assembly. It seems the request is made on what becomes the root assembly, but that can be the first assembly in the assembly tab. The actual root assembly has the same name as the tab.

I fixed this in our fork, but reporting it here FYI.
@Gregwar
Copy link
Contributor

Gregwar commented Jul 4, 2022

Hello Ryan,

Thanks for your PRs!
I will likely not be able to review them anytime soon since I am currently preparing for RoboCup 2022 that will be held next week

Do not hesitate to ping be again mid-july!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Gregwar @rsinnet