Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing UIDs for rhobs logs dashboards #398

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Feb 1, 2023

Some of the mixin-vendored Dashboard from grafana/loki are missing UIDs. This is not a mandatory requirement for Grafana dashboard being provisioned though a ConfigMap. This change makes the observatorium-logs/grafana-dashboards-template.yaml deployable again.

@periklis periklis self-assigned this Feb 1, 2023
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@periklis periklis merged commit 6bc4a55 into rhobs:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants