Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rhobs-logs] Add missing dashboards and metric name workarounds #407

Merged
merged 1 commit into from Feb 14, 2023

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Feb 14, 2023

The following change set provides a couple of fixes to address a couple of issues using our RHOBS logs dashboards on production:

  1. Adds the missing recording rules to address broken panel in Loki Operational, Loki Writes and Loki Reads dashboards.
  2. Renames a couple of metric names with simple string replacement (e.g. cortex_s3_* to `loki_s3_*). These are workarounds to tackle with the fact that our loki-mixin is still from 2020 and is not 100% compatible with Loki 2.7.x (currently used). The loki-mixin update will be addressed in a follow-up PR, because it is more complicated to resolve all ksonnet incompatibilities (See LOG-3622)

Ref: `LOG-3623

@periklis periklis self-assigned this Feb 14, 2023
@periklis periklis force-pushed the fix-rhobs-logs-dashboards-and-rules branch from 4f01ce6 to 24bd2b3 Compare February 14, 2023 11:22
@periklis periklis force-pushed the fix-rhobs-logs-dashboards-and-rules branch from 24bd2b3 to b2adcb9 Compare February 14, 2023 13:15
@periklis periklis merged commit 7e9fc25 into rhobs:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants