Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rhobs-logs] Refactor dashboard customizations #415

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[rhobs-logs] Refactor dashboard customizations #415

merged 1 commit into from
Feb 27, 2023

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Feb 23, 2023 •
edited

Refactor long due issues in managing dashboard customizations:

  1. Replace for-comprehensions in patching panels with more functional alternatives.
  2. Add units to all latency graphs.

Depends on

@periklis periklis self-assigned this Feb 23, 2023
@periklis periklis force-pushed the refactor-log-panels branch 2 times, most recently from 34a8e79 to 9e64d2e Compare February 27, 2023 09:12
saswatamcode
saswatamcode reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good, mod some comments about the more complex functions.

observability/config.libsonnet Show resolved Hide resolved
observability/config.libsonnet Outdated Show resolved Hide resolved
observability/config.libsonnet Outdated Show resolved Hide resolved
saswatamcode
saswatamcode approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@periklis periklis merged commit 1fbe3ae into rhobs:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

Assignees

@periklis periklis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@periklis @saswatamcode