Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to get a builder from a Retryer instance for further customisation #13

Open
andreisavu opened this issue Mar 17, 2014 · 2 comments

Comments

@andreisavu
Copy link

Sometimes the code that's using the Retreyer instance needs to add more conditions or update the retry / wait strategies.

@rholder
Copy link
Owner

rholder commented Mar 24, 2014

This could be quite useful. I'm thinking just returning the builder that was used to create the Retryer instance might be the simplest way to go here. It can then be updated and a new instance can be built with the new settings. Swapping out the old Retryer instance and updating the builder might have some thread safety implications, but overall it'd still be nice to have. Did you have a better API in mind that you'd prefer to use? I'm open to suggestions (and pull requests...).

@andreisavu
Copy link
Author

Agree - exposing the initial builder should be enough. I'm still exploring options. Safe publication is something the library user should handle anyway.

@rholder rholder added this to the 2.0.0 milestone May 3, 2015
rholder added a commit that referenced this issue Jun 20, 2015
@rholder rholder removed this from the 2.0.0 milestone Jun 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants